Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go to 1.16 #4706

Merged
merged 9 commits into from
Sep 16, 2022
Merged

Upgrade go to 1.16 #4706

merged 9 commits into from
Sep 16, 2022

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Sep 15, 2022 •
edited
Loading

What problem does this PR solve?

What is changed and how does it work?

Upgrade go versions to 1.16 in all go.mod.

Upgrade go versions to 1.16 in e2e

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #4706 (4e8aee5) into master (9d80655) will decrease coverage by 2.42%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4706      +/-   ##
==========================================
- Coverage   62.41%   59.99%   -2.43%     
==========================================
  Files         196      175      -21     
  Lines       21781    21908     +127     
==========================================
- Hits        13595    13144     -451     
- Misses       6942     7309     +367     
- Partials     1244     1455     +211
Flag Coverage Δ
e2e 59.99% <0.00%> (?)
unittest ?

@liubog2008
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member

/test pull-e2e-kind-tikv-scale-simultaneously

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-serial

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

4 similar comments
@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@xhebox xhebox mentioned this pull request Sep 16, 2022
Merged
8 tasks
@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

1 similar comment
@liubog2008
Copy link
Member

/test pull-e2e-kind

@KanShiori KanShiori merged commit 89faa4d into pingcap:master Sep 16, 2022
@KanShiori KanShiori deleted the go-1.16 branch September 16, 2022 14:49
@ti-srebot ti-srebot mentioned this pull request Oct 10, 2022
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.3 in PR #4738

ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Oct 10, 2022
@KanShiori @ti-srebot
cherry pick pingcap#4706 to release-1.3
c39e8c7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
csuzhangxc pushed a commit that referenced this pull request Feb 14, 2023
@ti-srebot @KanShiori
Upgrade go to 1.16 (#4706) #4738
e1ad97d 
Co-authored-by: Shiori <sihao.yu@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@handlerww handlerww Awaiting requested review from handlerww

Assignees
No one assigned
Labels
needs-cherry-pick-1.3 status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KanShiori @ti-chi-bot @codecov-commenter @liubog2008 @csuzhangxc @ti-srebot